search

0x09 / hfsfuse

FUSE driver for HFS+ filesystems
Other
77 stars 13 forks source link

Fix erroneous prefix matches in HFSX binary comparison #4

Closed DHowett closed 6 years ago

DHowett commented 6 years ago

This fixes the case where dir_205123 would erroneously match dir_205.

This commit completes the FIXME and removes (obviates) the special cases for zero-length keys on both sides.

Signed-off-by: Dustin L. Howett dustin@howett.net

This is perhaps a more contentious change; it ditches the memcmp in favor of a hand-rolled implementation. The early returns for zero-length keys aren't necessary this way, and it does seem to address the FIXME.

DHowett commented 6 years ago

Regarding keeping the diffs from NetBSD small: that makes sense! I've amended the changeset. :smile: Thanks!

0x09 commented 6 years ago

Just a heads up, I merged in the current top of tree NetBSD code just now at 0x09/hfsfuse@7d70266 (hfsfuse was a few versions behind, but I put it off since the changes are entirely cosmetic). Since it's a large reformatting, there will likely be conflicts if you have edited anything else from lib/libhfs locally. But it should be easier to compare the two / apply any changes back.

DHowett commented 6 years ago

Excellent. Thanks!