search

0x0ade / XnaToFna

Relink games / tools using the XNA Framework 4.0 to use FNA instead
zlib License
52 stars 5 forks source link

Remove FFmpeg use in WaveBank/SoundEffect processors #12

Closed flibitijibibo closed 5 years ago

flibitijibibo commented 6 years ago

Now that FNA's on FAudio, it's much more realistic for us to include WMA support as a native feature:

https://github.com/FNA-XNA/FAudio/issues/32

This should be removed and effort should go towards WMA support in FAudio.

flibitijibibo commented 6 years ago

The FFmpeg patch is now in, so removal of this stuff can start whenever someone has time.

0x0ade commented 6 years ago

Gonna work on it later this week now that the FAudio patch is finally merged in 🎉

Sidenote: I know that someone in the Terraria modding community uses the audio content transformers. Luckily they've already copied the necessary code from XnaToFna to their own project, but I'd like to keep it somewhere if it finds some use for someone in the future ever again (it really shouldn't - it's horrible).

0x0ade commented 5 years ago

I've just removed the content transformers entirely: https://github.com/0x0ade/XnaToFna/commit/c6bd2501b6760cc8405140d5000eac92f1e4514a

The remaining X360 changes should be part of FAudio in my opinion. Hopefully I'll be able to find some time this month to make FAudio swap the endianness as needed without introducing too much overhead.