search

0x0ece / yopa-native

0 stars 2 forks source link

Fingerprint not working on Android #102

Open 0x0ece opened 6 years ago

0x0ece commented 6 years ago

Currently we have a patch that basically bypasses fingerprint on Android.

According to Expo docs we should pass a component that renders to ask the user for fingerprint, but there's no working example.

We should decide what to do, an option is to turn deviceSecurity off in Android, that should simply never show the fingerprint options.

0x0ece commented 6 years ago

It's prob a permission issue -- or at least, for sure we need to add permissions, then there's probably more.

0x0ece commented 6 years ago

Fixed the permission issue here: https://github.com/0x0ece/yopa-native/pull/111

The problem is now the following. On Android, we should have a modal that prompt the user to use the fingerprint. Other than building the modal, we should have a cancel button that rejects the fingerprint promise.

I've opened a feature request on Expo: https://expo.canny.io/feature-requests/p/fingerprint-screen-on-android

I'm NOT going to work on this, so feel free to take it over.

nax83 commented 6 years ago

What do you plan to do with this feature? Shall we try to implement it before publishing on Android? Otherwise we could do a recap about what's missing

0x0ece commented 6 years ago

Fingerprint itself is working on Android. The problem, as I've explained, is that the user doesn't know.

So the feature to build is a modal (similar as the one on iOS). The complexity in this modal is just the "cancel" button, which is pretty important though.

IMO this is a pretty important feature for Android and I'd wait to have it before releasing on the store, but I leave the last word to you. I doubt that any user would be happy to type in the master password every single time.

I don't see anything else missing for Android (expect marketing-related stuff, but I can work on these).