search

0x0ece / yopa-native

0 stars 2 forks source link

Add service should add at the top #23

Closed 0x0ece closed 6 years ago

0x0ece commented 7 years ago

Super quick change in reducers / ADD_SERVICE.

davidevernizzi commented 6 years ago

Should add at the top or should we sort the secrets somehow?

0x0ece commented 6 years ago

I think top is strictly better than now (bottom), so I'd go top for the mvp, and then we can think about it.

The real deal is search IMO, as any sort has its own drawbacks.

In reality if you add a new service you may need the secret soon (because you're logging in maybe on multiple devices), then you forget about it until you really need that -- and so you search.

davidevernizzi commented 6 years ago

I think top is strictly better than now (bottom), so I'd go top for the mvp, and then we can think about it.

OK

The real deal is search IMO, as any sort has its own drawbacks.

Agree, but we need to make search smart and fast. Especially fast.

In reality if you add a new service you may need the secret soon (because you're logging in maybe on multiple devices), then you forget about it until you really need that -- and so you search.

Good point. Maybe we could copy the secret when you add one. I'll implement the basic version today and we discuss on this point.

Mine.