0x0ece / yopa-native

0 stars 2 forks source link

The "placeholder" option should be nested under "attrs" #33

Closed psmiraglia closed 6 years ago

psmiraglia commented 6 years ago

According to latest tcomb-form documentation, the following options

https://github.com/0x0ece/yopa-native/blob/a4ff092b3a0928e235b537e9d2710f226e737c79/src/screens/AddServiceScreen.js#L79-L93

should be changed in something like that

fields: {
  service: {
    attrs: { 
      placeholder: 'example.com', 
    },
  }, 
  username: { 
    label: 'Username or email', 
    attrs: {
      placeholder: 'mempa', 
   },
  },
  ... 
}

I used your code with tcomb-form version 0.9.17 and the placeholder is not shown.

0x0ece commented 6 years ago

Good catch!

davidevernizzi commented 6 years ago

Mine, since I'm working on these screens.

0x0ece commented 6 years ago

Other minor but powerful options:

                autoCapitalize: 'none',
                autoCorrect: false,
                autoFocus: true,
davidevernizzi commented 6 years ago

I'm closing this because it's not working as described in the doc.