search

0x0ece / yopa-native

0 stars 2 forks source link

Common components as NodeJS module #34

Closed psmiraglia closed 6 years ago

psmiraglia commented 6 years ago

The native apps and the Chrome extension will share some elements (e.g. Crypto.js). In order to avoid misalignment among the environments, I think it could be useful to have the shared elements as independent module (maybe mempa-common), which can be then imported in each project. What do you think about that?

0x0ece commented 6 years ago

It's a very good idea, yesterday I was looking at lesspass and they have a pretty good organization of the various packages, we can learn from them.

Personally I'd wait to refactor until after the MVPs, for now we can copy Crypto.js and also change it independently in the two projects to go faster. I don't except we'll do a ton of incompatible changes so it will be a quick merge in the end.

0x0ece commented 6 years ago

This is also another interesting perspective: https://danluu.com/monorepo/

We should have a chat after we have the MVPs and before proceeding.

psmiraglia commented 6 years ago

I created mempa-core (https://github.com/psmiraglia/mempa-core) and I will use it to develop the Chrome extension. It is mainly an exercise to understand how to create Node modules and how to use JSDoc.

0x0ece commented 6 years ago

+1, closing the issue then.