0x0ece / yopa-native

0 stars 2 forks source link

UI improvements #47

Closed 0x0ece closed 6 years ago

0x0ece commented 6 years ago

@jacksilv I slightly reviewed the search. I did it like I was proposing, always visible and offsetting the FlatList - I believe this is how it's done in most of ios apps, at least Apple's ones. I've made it slightly bigger (44px + 4px margin) just so it's the same size as the other elements.

jacksilv commented 6 years ago

Good Job! I tested it and I like the new search behaviour. To be even more iOS compliant we could use a border on the bottom of the header that disappears when the serachbox is show and a border at the bottom of the searchbox that replaces it, as if the searchbox was part of an extendend header (e.g., Setting in ios11). It should also be possible to hide the searchbar when the searchString is empty by scrolling the list up.