search

0x0ece / yopa-native

0 stars 2 forks source link

Create site in current group #58

Closed jacksilv closed 6 years ago

jacksilv commented 6 years ago

When a user add a site from inside a group the Group value is pre-filled with "default" no matter which group is currently selected.

Expected behaviour: The Group value matches the current group

0x0ece commented 6 years ago

Also, let's only list the initialized groups. In particular, if the list of the initialized groups is only ['default'], then we don't display the dropdown, exactly as it is right now.

See explanation in test Onboard04: https://docs.google.com/spreadsheets/d/1cfPzxcLIXT0y3F2Vy78tdnXNi6QCBp72WxxfcLMD1a4/edit#gid=0

0x0ece commented 6 years ago

Maybe it's a good idea to have 2 static methods getGroupList(groups) and showGroup(groups), so that we can write a couple of simple unit tests (no need for rendering react components) for this logic.