search

0x0ece / yopa-native

0 stars 2 forks source link

Integrate CI #60

Closed 0x0ece closed 6 years ago

0x0ece commented 6 years ago

Integrate some CI framework, so that every PR that we send is tested and linted.

We should also prob write some pre-commit hooks, so we're warned in advance.

kalamaico commented 6 years ago

https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo

Need admin access to the project, or need an admin to do a few steps for me :)

0x0ece commented 6 years ago

Mmm...

  1. I just realized that Travis CI is pago-ware for private projects: https://travis-ci.com/plans

  2. There's no way to give admin access for personal private repos :/ (that I have free/unlimited)

So... I guess I'll have to connect it myself :( I'll try with https://circleci.com Unless anyone knows/proposes anything better. Also cc @psmiraglia

psmiraglia commented 6 years ago

I took a rapid look under GitHub Marketplace / CI and the only interesting things are Travis and Circle. We can approach by including both the environments (.travis.yml and .circleci) within the repos. Then, we'll chose at runtime which will be the winner.

0x0ece commented 6 years ago

Ok - I'll connect circle then.

psmiraglia commented 6 years ago

FYI, connected Circle CI to mempa-core.

Soon on chrome-mempa...

psmiraglia commented 6 years ago

I made some experiments with CircleCI and it seems to be a bit "resourcefull" for my tastes. I mean... until repos are public it works well. When it has to run on private ones, it requires too much permissions.

In my case, chrome-mempa uses mempa-core as dependency and both are private repos. Since CircleCI injected different keys to access the repos, the build of chrome-mempa fails. CircleCI suggests a solution to fix this problem, but it requires the full permission to manage SSH keys related to my account. It's too much for me...

@0x0ece @kalamaico what do you think about that?

psmiraglia commented 6 years ago

It sounds better... https://circleci.com/docs/2.0/gh-bb-integration/#machine-user-keys

0x0ece commented 6 years ago

I just found another "glitch" as Jacopo's PR has not been built.

For the long, long term, every day I'm getting a bit more convinced that we should go for a mono repo.

0x0ece commented 6 years ago

I think I've fixed. I'm closing this.