search

0x192 / universal-android-debloater

Cross-platform GUI written in Rust using ADB to debloat non-rooted android devices. Improve your privacy, the security and battery life of your device.
GNU General Public License v3.0
15.59k stars 825 forks source link

UAD is terminated #128

Closed kbudack closed 2 years ago

kbudack commented 2 years ago

Describe the bug after each change on a SM-T545 the UAD is terminated.

UAD log Upload the logfile generated by UAD. UAD_20220211.log

0x192 commented 2 years ago

You mean that UAD crashes?

Reading the logfile tells me that there is a permission issue when trying to uninstall the app for the user 150 (Secure Folder). Unfortunately we can't do anything:

Samsung has restricted privileges of adb (shell) user from making changes to packages installed under user 150. There is nothing we can do. This is a design choice (probably to ensure bloat continues to float in the device). Rooting is the only solution to remove bloatware in such situations Firelord -- android.stackexchange

KarlRamstedt commented 2 years ago

@kbudack deselect the "Affect all the users of the phone (not only the selected user)" option in Settings if it's selected. As long as UAD isn't trying to uninstall from user 150, it shouldn't "terminate"?

@0x192 if "terminate" means crash in this case it might be worth looking into some basic error handling when UAD can't disable/uninstall certain packages. Just something as simple as:

try {
    Uninstall(package);
}
catch {
    ShowErrorMessage();
}

(psuedo-code to illustrate basic structure, I don't know the syntax of Rust) And maybe parse the error message from the console to the GUI error popup for clarity?

0x192 commented 2 years ago

if "terminate" means crash in this case it might be worth looking into some basic error handling when UAD can't disable/uninstall certain packages

FYI, UAD won't crash if an ADB command fail. The user will be able to see that the state of the package didn't change.

I don't really know how to nicely integrate those error messages in the GUI and Iced doesn't have a popup widget yet.

@kbudack No further information being provided, I close the issue. I will still see your reply if you come back.