0x1F9F1 / Open1560

A mod for Midtown Madness 1, primarily focused on supporting modern computers and fixing bugs.
https://0x1F9F1.github.io/Open1560
GNU General Public License v3.0
110 stars 9 forks source link

Rear view mirror breaks depth testing in software mode #104

Closed 0x1F9F1 closed 1 year ago

0x1F9F1 commented 3 years ago

In some parts of the map, enabing the rear view mirror can break depth testing. It also seems to change the shdaow color. SHOT0001 SHOT0002

0x1F9F1 commented 3 years ago

When software rendering is enabled, mmDrawbridgeInstance::Draw sets ZEnable = 1 before drawing, and ZEnable = 0 afterwards, instead of restoring the previous value

0x1F9F1 commented 3 years ago

Disabling VisitTags in mmCellRenderer::Cull by patching the jump at 0x49968C fixes the issue, though it is not clear why.

0x1F9F1 commented 3 years ago

The shadow issues were fixed by d90b2294e217fc2f157f51862461194f53036cee

0x1F9F1 commented 1 year ago

Disabling VisitTags in mmCellRenderer::Cull by patching the jump at 0x49968C fixes the issue, though it is not clear why.

This should now be fixed in 5e45760cde29089877f7d6c698ff22aa3febd1b4 (though I haven't tested it extensively).