0x2142 / frigate-notify

Event notifications for a standalone Frigate NVR instance
https://frigate-notify.0x2142.com/
MIT License
107 stars 9 forks source link

"unzoned: drop" never notifies #118

Closed lubomir-moric closed 3 months ago

lubomir-moric commented 3 months ago

Describe the bug After upgrade to v0.3.3, using unzoned: drop all notifications from Frigate are dropped and claimed as unzoned.

Expected behavior Only unzoned events are dropped.

To Reproduce Steps to reproduce the behavior:

Versions:

Frigate-Notify Config:

alerts:
  zones:
    unzoned: drop

Frigate-Notify Logs:

frigate-notify  | 2024/08/15 16:22:12 +0200 INF events/mqtt.go:67 > Event update received event_id=1723670881.760396-138hna
frigate-notify  | 2024/08/15 16:22:12 +0200 INF events/mqtt.go:85 > Event Detected camera=Vchod event_id=1723670881.760396-138hna label=car zones=garaz
frigate-notify  | 2024/08/15 16:22:12 +0200 DBG events/mqtt.go:88 > Event start time: 2024-08-14 23:28:01 +0200 CEST event_id=1723670881.760396-138hna
frigate-notify  | 2024/08/15 16:22:12 +0200 INF events/filters.go:76 > Event dropped - Outside of zone. event_id=1723670881.760396-138hna zones=

Additional context When removing unzoned from config, everything is notified, even when zone is not defined in "zones: -> allow: ...". Seems there is some issue in notification filtering logic. In log there is visible, that filters.go is missing the zone, it is suddenly empty. In v 0.3.2 there was not such issue.

0x2142 commented 3 months ago

Thanks for reporting this. I can replicate & I see what is causing it.. Let me see if I can get a fix out quickly for you 👍

0x2142 commented 3 months ago

New release building now with the fix, should be available shortly!

v0.3.4 is out & has the fix for this 👍