search

0x4007 / ubiquibot

Ubiquity GitHub Bot
MIT License
0 stars 2 forks source link

feat: integrate infrastructure #52

Closed wannacfuture closed 1 year ago

wannacfuture commented 1 year ago

Resolves #

Quality Assurance:

0x4007 commented 1 year ago

This is an interesting approach. For some reason I figured that the secretToken would be set in the ubiquibot-config repo secrets instead. Is transmitting it from the other repo the superior choice? If so, why?

https://github.com/wannacfuture/ubiquibot-config/blob/d3e49c8f44183a033459cb1257695df4018c95a5/.github/workflows/bridge.yml#L21-L23

wannacfuture commented 1 year ago

This is an interesting approach. For some reason I figured that the secretToken would be set in the ubiquibot-config repo secrets instead. Is transmitting it from the other repo the superior choice? If so, why?

https://github.com/wannacfuture/ubiquibot-config/blob/d3e49c8f44183a033459cb1257695df4018c95a5/.github/workflows/bridge.yml#L21-L23

We need to return the response to the original repo. And for that, we need to put secret token as the payload for the request. https://github.com/wannacfuture/ubiquibot-config/blob/d3e49c8f44183a033459cb1257695df4018c95a5/.github/workflows/bridge.yml#L42C1-L48C172

0x4007 commented 1 year ago

I think it makes sense to rename bridge.yml to compute.yml or something of the like, because I don't want it to be confused with bridges as we see in DeFi.

0x4007 commented 1 year ago

Is there any extra setup required other than pushing bridge.yml to @pavlovcik/ubiquibot-config? I'm leaning towards merging this so I can continue working today.