search

0x4b53 / amqp-rpc

🐰 Framework to use RabbitMQ as RPC
MIT License
45 stars 8 forks source link

Qos and Expiration #74

Closed akarl closed 5 years ago

akarl commented 5 years ago
  1. Set a default QoS.
  2. Don't set timeout when no reply is wanted.
bombsimon commented 5 years ago

Great with default QoS and prefetch count! Does this solve #72? Can we document this? Can I set this for both the channel to affect all bindings and per binding? If so, do you mind documenting it?

akarl commented 5 years ago

I'm not sure where/how to make this configurable. At the moment a user can not set the exchangeDelcareSettings, queueDeclareSettings and consumeSettings. Should we have Server.WithExchangeDeclareSettings, Server.WithQueueDeclareSettings and Server.WithConsumeSettings?

bombsimon commented 5 years ago

I'm not sure where/how to make this configurable. At the moment a user can not set the exchangeDelcareSettings, queueDeclareSettings and consumeSettings. Should we have Server.WithExchangeDeclareSettings, Server.WithQueueDeclareSettings and Server.WithConsumeSettings?

Yeah I think so. Or at least that's how we do it on the client. So either that or make the fields public (on both server and client). I think I kind of like the with-part since all other configurable parameters are set that way.

sieuwerts commented 5 years ago

I think that this looks really good, I also think that the code climate warning about the method being too long is a bit too strict. The method is easy to follow and already broken down into what I consider to be enough.