Closed akarl closed 5 years ago
Great with default QoS and prefetch count! Does this solve #72? Can we document this? Can I set this for both the channel to affect all bindings and per binding? If so, do you mind documenting it?
I'm not sure where/how to make this configurable. At the moment a user can not set the exchangeDelcareSettings
, queueDeclareSettings
and consumeSettings
. Should we have Server.WithExchangeDeclareSettings
, Server.WithQueueDeclareSettings
and Server.WithConsumeSettings
?
I'm not sure where/how to make this configurable. At the moment a user can not set the
exchangeDelcareSettings
,queueDeclareSettings
andconsumeSettings
. Should we haveServer.WithExchangeDeclareSettings
,Server.WithQueueDeclareSettings
andServer.WithConsumeSettings
?
Yeah I think so. Or at least that's how we do it on the client. So either that or make the fields public (on both server and client). I think I kind of like the with-part since all other configurable parameters are set that way.
I think that this looks really good, I also think that the code climate warning about the method being too long is a bit too strict. The method is easy to follow and already broken down into what I consider to be enough.