search

0x4b53 / amqp-rpc

🐰 Framework to use RabbitMQ as RPC
MIT License
45 stars 8 forks source link

Update names and pipelines + WSL #79

Closed bombsimon closed 5 years ago

bombsimon commented 5 years ago

Now that wsl is a part of golangci-lint I made the project pass.

Also, this let's us test pipelines and other settings from #78

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 887aa277 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.1%.

View more on Code Climate.

bombsimon commented 5 years ago

Pending — GolangCI is reviewing your Pull Request...

Come on GolangCI, you can do this!

bombsimon commented 5 years ago

This resolves #78

@akarl, @sieuwerts, @biffen Could you please merge this (and thus close #78) when you feel ready? GitHub does handle the redirects but with go modules things get broken. Trying to import this from 0x4b53:

go: finding github.com/0x4b53/amqp-rpc v0.10.0
go: downloading github.com/0x4b53/amqp-rpc v0.10.0
go: extracting github.com/0x4b53/amqp-rpc v0.10.0
go get: github.com/0x4b53/amqp-rpc@v0.10.0: parsing go.mod:
        module declares its path as: github.com/bombsimon/amqp-rpc
                but was required as: github.com/0x4b53/amqp-rpc

I could only imagine this issue getting reverse if merging.

I actually have no idea how to solve this kind of issues. I guess this is a minor with the few users but how would a larger project do this? And if this gets merged all pipelines using the old naming would need to be updated?