search

0x4b53 / amqp-rpc

🐰 Framework to use RabbitMQ as RPC
MIT License
45 stars 8 forks source link

Various bugfixes #84

Closed sieuwerts closed 4 years ago

bombsimon commented 4 years ago

If you install the bundled hooks this type of mistakes won't happen again. :) 

make hooks

There's a pre-commit hook that won't let you commit code that doesn't pass the linting step.

bombsimon commented 4 years ago

Weird, the diff coverage percentage is configured to 50%? Or am I missing something?

image

EDIT: Ah, it's the amount of new code. So I'll untick the Enforce Total Coverage box.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 231ae58b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 93.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.6% (0.1% change).

View more on Code Climate.

akarl commented 4 years ago

Hmm total coverage isn't reported in the "checks" but in the comment it says "This pull request will bring the total coverage in the repository to 88.6% (0.1% change)." so I'm going to merge this anyway.