Closed sieuwerts closed 4 years ago
Weird, the diff coverage percentage is configured to 50%? Or am I missing something?
EDIT: Ah, it's the amount of new code. So I'll untick the Enforce Total Coverage
box.
Code Climate has analyzed commit 231ae58b and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 93.3% (50% is the threshold).
This pull request will bring the total coverage in the repository to 88.6% (0.1% change).
View more on Code Climate.
Hmm total coverage isn't reported in the "checks" but in the comment it says "This pull request will bring the total coverage in the repository to 88.6% (0.1% change)." so I'm going to merge this anyway.
If you install the bundled hooks this type of mistakes won't happen again. :)
There's a pre-commit hook that won't let you commit code that doesn't pass the linting step.