search

0x4b53 / amqp-rpc

🐰 Framework to use RabbitMQ as RPC
MIT License
45 stars 8 forks source link

Make fanout server queues exclusive. Closes #89 #90

Closed bombsimon closed 1 year ago

bombsimon commented 3 years ago

This will ensure that the reply queues are deleted when the example is finished without having to manually delete them or restart the server.

I feel like there should be a way to simply not create the queue at all, but this is basically exactly the way the documentation does it (and can also be found in the rabbitmq-tutorials repository).

Should we find a different way to handle this or just leave this as is? I didn't spend too much time looking into how we handle other bindings when we set reply to false, would this be possible to handle in a similar way?

Leaving this PR like this for now, it's at least a solution to #89.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 27fbd638 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.