0x5bfa / FluentHub

A stylish yet powerful GitHub client for Windows
MIT License
1.08k stars 53 forks source link

App crashes after authorizing #104

Closed AstroX809 closed 2 years ago

AstroX809 commented 2 years ago

Before you start...

What windows are you seeing the problem on?

Windows 11 Beta

What FluentHub version/architecture are you seeing the problem on?

0.8.25.0

Description

I opened the app, I clicked on "Start Setup", the app asked me to login with me Github account, after authenticating the app immediately crashed.

Steps To Reproduce

  1. Open the app
  2. Click "Start Setup"
  3. Click "Open with your browser"
  4. Authenticate in the Github page
  5. The app crashes

Expected behavior

I expected the app to take me to the next page in the setup process.

Relevant Assets

https://streamable.com/ngcdv5

0x5bfa commented 2 years ago

Very important.

senolfndk commented 2 years ago

ayen is crashing on me too

senolfndk commented 2 years ago

crashing

https://user-images.githubusercontent.com/52818836/161305548-c4f1706f-8e0f-4cb1-88c9-1393bd829c3f.mp4

0x5bfa commented 2 years ago

okey which version? 0.7.13?

senolfndk commented 2 years ago

0.7.13 version

0x5bfa commented 2 years ago

confirmed. I will fix sorry.

senolfndk commented 2 years ago

ok

0x5bfa commented 2 years ago

@senolfndk this is first launch? yet dont auth?

0x5bfa commented 2 years ago

Building with the same build version DEBUG configuration will absolutely succeed. However, when run with a RELEASE build, it seems to fail after authentication. My thinking is that in the RELEASE build, the exception that should be caught by try-catch is not being caught.

johngagefaulkner commented 2 years ago

Building with the same build version DEBUG configuration will absolutely succeed. However, when run with a RELEASE build, it seems to fail after authentication. My thinking is that in the RELEASE build, the exception that should be caught by try-catch is not being caught.

Building 0.7.13 with DEBUG configuration does not succeed, either. The application does not "crash" but it sits at the "loading" screen after authentication forever (never continues/progresses forward.)

0x5bfa commented 2 years ago

@johngagefaulkner Sorry for the inconveniences. your feedback is very important. thank you. I launched v0.7.13 right now and it seems to stop when OnLaunch or OnActivated takes too long. After that version the post-authentication behavior has changed.

Please these steps:

  1. Uninstall app
  2. Re-generate client secret and put them to config file.
  3. Build latest head/main branch.
  4. Let me know if app success.

If so, I will tag v0.7.15

johngagefaulkner commented 2 years ago

@johngagefaulkner Sorry for the inconveniences. your feedback is very important. thank you. I launched v0.7.13 right now and it seems to stop when OnLaunch or OnActivated takes too long. After that version the post-authentication behavior has changed.

Please these steps:

  1. Uninstall app

  2. Re-generate client secret and put them to config file.

  3. Build latest head/main branch.

  4. Let me know if app success.

If so, I will tag v0.7.15

Yeah, give me 30 minutes, I went to get breakfast. Then I'll build & test.

0x5bfa commented 2 years ago

Latest RELEASE pipeline I did. from sideload pipeline artifacts

image

Same issue.

stopping this page.

image

johngagefaulkner commented 2 years ago

@onein528 Are you saying you just tested the most recent build and it isn't working for you, either? Is it throwing an exception? If so, what's the error message?

0x5bfa commented 2 years ago

latest version configured RELEASE does not work(same. suspending). but latest version configured DEBUG does work property.

0x5bfa commented 2 years ago

It is impossible to know what is wrong with an application in the RELEASE configuration because it cannot be debugged. However, when I run the app in DEBUG configuration, it succeeds for some reason.

senolfndk commented 2 years ago

https://user-images.githubusercontent.com/52818836/161771061-39da2fcc-c6ba-4b27-8df4-6d0d49a1ebad.mp4

🙁

0x5bfa commented 2 years ago

yeah....

0x5bfa commented 2 years ago

@johngagefaulkner can you build latest branch?

senolfndk commented 2 years ago

Ekran görüntüsü 2022-04-05 170648

0x5bfa commented 2 years ago

appinstaller cannot be launch.

use msixbundle

senolfndk commented 2 years ago

are you saying that

Ekran görüntüsü 2022-04-05 171224

0x5bfa commented 2 years ago

yes get from where? release page?

senolfndk commented 2 years ago

Evet

i already installed this

0x5bfa commented 2 years ago

can you build source code of latest head/main branch?

senolfndk commented 2 years ago

en son ana/ana dalın kaynak kodunu oluşturabilir misiniz?

I don't know how to generate code

0x5bfa commented 2 years ago

OK. now, the app package, configured RELEASE, will be remove until become stable version V1.

We do apologize for any inconvenience caused. but i cannot found what is wrong with sideload package. so if you want to use this, you need to build app. if you cannot, please wait when published on Microsoft Store(v1.0.0).

I don't know how to generate code

take a look at our building documentation.

senolfndk commented 2 years ago

TAMAM. şimdi, RELEASE olarak yapılandırılmış uygulama paketi, kararlı sürüm V1 olana kadar kaldırılacaktır.

Verdiğimiz rahatsızlıktan dolayı özür dileriz. ama sideload paketinde neyin yanlış olduğunu bulamıyorum. bu yüzden bunu kullanmak istiyorsanız, uygulama oluşturmanız gerekir. yapamazsanız, lütfen Microsoft Store(v1.0.0)'da yayınlandığında bekleyin.

ok

BobbyESP commented 2 years ago

This still occuring or the issue can be closed?

grumpy-photographer commented 2 years ago

So far when I build, I keep getting it. I'm building every day after any changes. The app knows it's me but the UI doesn't. I'm assuming that has something to do with stored credentials. I can send screenshots and logs later, but I have to get ready for work.

0x5bfa commented 2 years ago

Thanks. I wonder we can build successfully absolutely. so we are looking forward failed logs.

grumpy-photographer commented 2 years ago

Sure thing. I'll get back on this later today after work.

grumpy-photographer commented 2 years ago

I'm not 100% sure what you need/want but I tried to gather what I think may be helpful. Let me know if you need anything else.

Just so you know, I'm running Win 11 Dev Build 22598, using Visual Studio 2022 v17.1.5, and running off the Main branch which appears to be FluentHub v0.7.13.0.

Here's the build section:

https://user-images.githubusercontent.com/46688736/164554189-faa8a458-a42f-45a3-ad2e-5e458f87bf2e.mp4

And the debug/deploy. I tried to show what I was attempting to describe earlier with the app knowing it's me but the UI not (that explanation is starting to not make any sense to me 😂). Basically, you can see that the Home page doesn't recognize my account, but when I go to Notifications, it's pulling those in perfectly.

https://user-images.githubusercontent.com/46688736/164554566-1d5e2248-bb6d-4c28-b733-5685b93e20c7.mp4

And here's the sign in issue still occuring:

https://user-images.githubusercontent.com/46688736/164554718-e44420b1-9472-43d7-90eb-74750dfd2625.mp4

Here's the log. I don't see this capturing the sign in, just the failure to get the user information on the Home page. Log20220421.log

BobbyESP commented 2 years ago

Yeah, we haven't implemented yet all the things to the log maker. I'm gonna try to reproduce the problem and i tell you.

BobbyESP commented 2 years ago

For me all worked well. Now i can't continue investigating because i need to go to sleep. Tomorrow i'll take a deep investigation, and if i cant found the problem, i dont know if you liked to make a screen sharing on Discord. Thanks for the report and sorry for the inconveniences.

grumpy-photographer commented 2 years ago

Bummer. This happens to me at work all the time, everything works for me but is broken for everyone else ha. Thanks for taking a look. As for the discord, the link in the README, at least for me, is just a link to the channel, not an invite. When I click it I just get taken to the discord app, not the server/channel...

BobbyESP commented 2 years ago

Ohh, no problem, i change it now!

BobbyESP commented 2 years ago

https://discord.gg/geWQjmvTZV

grumpy-photographer commented 2 years ago

Thanks!

0x5bfa commented 2 years ago

I will make logging better in current PR.

you can access log location in settings -> about page. And please give your log file.

BobbyESP commented 2 years ago

He already sent the log -> https://github.com/fluenthub-community/FluentHub/files/8535166/Log20220421.log

0x5bfa commented 2 years ago

I think code does not store signed in username to app settings manager.

0x5bfa commented 2 years ago

@nathayoung nice feedback! thank you.

BobbyESP commented 2 years ago

123 Take a look to this issue. If your problem is not solved, we will reopen the issue.

0x5bfa commented 2 years ago

Duplicate of #123