search

0x5bfa / FluentHub

A stylish yet powerful GitHub client for Windows
MIT License
1.08k stars 52 forks source link

Empty space above notification on home page #249

Closed hunterlan closed 2 years ago

hunterlan commented 2 years ago

⏱️ Before you start...

🪟 What version of Windows is this issue present?

Windows 11

🔢 What version/architecture of FluentHub are you on?

The last commit of main branch (01.09.2022) :D

📄 Description

On the screenshot below, you can see that the space between buttons and notification on home page is huge and empty. I see that it reserved for other section, but maybe it's better to hide it for a time.

🪜 Steps To Reproduce

No response

🤔 Expected behavior

Space between list of notifications and buttons will be lesser.

📸 Assets

image

Lamparter commented 2 years ago

@hunterlan What branch are you building from?

hunterlan commented 2 years ago

@hunterlan What branch are you building from?

I have a forked repo, which is syncing with main branch

Lamparter commented 2 years ago

Ahh. This is a localisation error.

Lamparter commented 2 years ago

@hunterlan Use branch localise.

hunterlan commented 2 years ago

@hunterlan Use branch localise.

Why?

Lamparter commented 2 years ago

@hunterlan Use branch localise.

Why?

Because that fixes the error.

hunterlan commented 2 years ago

@hunterlan Use branch localise.

Why?

Because that fixes the error.

Oh, ok But localise branch will not be always actual, right?

Lamparter commented 2 years ago

UserHomePage.xaml is relying on locale resources that don't exist in the main branch. However, those resources are implemented in #244, or localise.

Lamparter commented 2 years ago

Oh, ok But localise branch will not be always actual, right?

Of course. Once all of FluentHub is successfully localised, we'll merge the PR and then you can use main correctly. For now, use localise.

hunterlan commented 2 years ago

UserHomePage.xaml is relying on locale resources that don't exist in the main branch. However, those resources are implemented in #244, or localise.

Got it. So, we will not have a merge conflicts, when I will create PR

Lamparter commented 2 years ago

UserHomePage.xaml is relying on locale resources that don't exist in the main branch. However, those resources are implemented in #244, or localise.

Got it. So, we will not have a merge conflicts, when I will create PR

You can create a PR anytime! Don't worry about merge conflicts. @hunterlan