0x5bfa / FluentHub

A stylish yet powerful GitHub client for Windows
MIT License
1.08k stars 53 forks source link

Repository page ScrollViewer position #31

Closed 0x5bfa closed 2 years ago

0x5bfa commented 2 years ago

Describe the bug As the title

To Reproduce Steps to reproduce the behavior:

  1. Go to repository page
  2. Scroll down

Expected behavior

I don't know where to make it scrollable.

Screenshots (optional)

Version

Additional context

0x5bfa commented 2 years ago

first suggestion(I think it maybe not bad)

image

second(currently):

image

third(out dated) image

0x5bfa commented 2 years ago

I have now inserted a script that disables vertical scrolling in WebView.

        private async void RepositoryReadmeWebView_NavigationCompleted(WebView sender, WebViewNavigationCompletedEventArgs args)
        {
            string returnStr = await RepositoryReadmeWebView.InvokeScriptAsync("eval", new string[] { SetBodyOverFlowHiddenString });
        }

        string SetBodyOverFlowHiddenString
            = @" function SetBodyOverFlowHidden()
                {
                    document.body.style.overflow = 'hidden';
                    return 'Set Style to hidden';
                }
                SetBodyOverFlowHidden();
            ";
BobbyESP commented 2 years ago

Ok, the idea is getting that down while scrolling? That's actually my idea

0x5bfa commented 2 years ago

yes which is would you like?

0x5bfa commented 2 years ago

second idea is good? or first?

BobbyESP commented 2 years ago

I thought in the first one, but if u like the second one, we can use it

0x5bfa commented 2 years ago

YES. go with first one