search

0x61726b / electron-vibrancy

Make your electron windows vibrant!
MIT License
655 stars 50 forks source link

Why the windows version was not merged to Electron? #33

Open wdanilo opened 4 years ago

wdanilo commented 4 years ago

Hi! This is amazing. Lack of Windows support in Electron is so sad having this solution. Would you be so nice and tell more about why it was not merged / if there are any plans of doing it ?

Toby56 commented 4 years ago

Probably because it's kindof a hack and has some issues.

bennymeg commented 4 years ago

It might be possible to implement it properly with NodeRT and this blur code example or this acrylic code example (win 10 only).

Gum-Joe commented 4 years ago

According to this https://docs.microsoft.com/en-us/windows/win32/apiindex/uwp-apis-callable-from-a-classic-desktop-app, APIs must have the DualApiPartition attribute to be called outside of UWP, which https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.media.acrylicbrush?view=winrt-19041 does not have. It seems to call it you need a "package identity" (https://docs.microsoft.com/en-us/windows/win32/apiindex/uwp-apis-callable-from-a-classic-desktop-app).

This could be of use: https://blogs.windows.com/windowsdeveloper/2019/10/29/identity-registration-and-activation-of-non-packaged-win32-apps/

Also there's WinUI 3....

bennymeg commented 4 years ago

You are right, the AcrylicBrush do not has DualApiPartition attribute, but the CompositionEffectBrush (for blurring) has.

danielehrhardt commented 3 years ago

Did someone get it to work?

drunkwinter commented 3 years ago

Fixed in my fork along with a cleanup, package updates and improvements. https://github.com/DrunkWinter/electron-vibrancy