search

0x6b / copy-selection-as-markdown

Firefox add-on to copy selection as Markdown
https://addons.mozilla.org/en-US/firefox/addon/copy-selection-as-markdown/
MIT License
183 stars 14 forks source link

Switch from `turndown-plugin-gfm` to `joplin-turndown-plugin-gfm` (or any other maintained fork) #81

Open alexanderadam opened 3 years ago

alexanderadam commented 3 years ago

The original plug-in is not maintained (last patch is from 3 years ago and PRs for bugfixes aren't merged) and it's not able to convert tables properly (see this or this).

But it seems that forks like joplin-turndown-plugin-gfm are well maintained and contain the bugfixes. Maybe there's a better fork but CGUs switched to this one as well.

PS: As always thank you so much for copy-selection-as-markdown. I'm using it every day! :+1:

0x6b commented 3 years ago

@alexanderadam Thank you for the suggestion. Really glad your feedback and it's totally my pleasure. The plugin you mentioned is really promising. I'll test it and get back to you (hopefully sooner but I have recently have limited bandwidth).

alexanderadam commented 3 years ago

I'll test it and get back to you (hopefully sooner but I have recently have limited bandwidth).

No pressure. Take your time, stay healthy and enjoy time with your loved ones. Maintaining FOSS is no obligation. :wink:

alexanderadam commented 3 years ago

Now there's also another fork. I don't know which one might be better, though. :man_shrugging:

It'd probably be easier to have fixes in a single fork than distributed over many, but I'm not making the rules. :disappointed:

0x6b commented 3 years ago

@alexanderadam Thanks for your patience and update for the issue. Newer fork looks good to me, as it might have a chance to merge into the original one. I'll compare these.

alexanderadam commented 3 years ago

@alexanderadam it might have a chance to merge into the original one.

What makes you think that? :thinking:

The old fork also has a PR ongoing… since 2018.

But the maintainer of the original project never merged it. I also asked the maintainer to explicitly mention at least, that the package isn't maintained.

0x6b commented 3 years ago

Ah I didn't know the https://github.com/domchristie/turndown-plugin-gfm/pull/10. Now it's difficult to compare 🤔

cebaa commented 3 months ago

Just wondered if this is still on the radar. Not sure how big of an effort it would be to switch.