0x6b / copy-selection-as-markdown

Firefox add-on to copy selection as Markdown
https://addons.mozilla.org/en-US/firefox/addon/copy-selection-as-markdown/
MIT License
190 stars 14 forks source link

Issues: Tables are not rendered correctly #98

Closed lamyergeier closed 8 months ago

lamyergeier commented 3 years ago

Source: Debits and credits - Wikipedia, under the heading: - Aspects of transactions

Actual Result On the other hand, increases in revenue, liability or equity accounts are credits or right side entries, and decreases are left side entries or debits.

 Kind of account

Debit

Credit

Asset

Increase

Decrease

Liability

Decrease

Increase

Income/Revenue

Decrease

Increase

Expense/Cost/Dividend

Increase

Decrease

Equity/Capital

Decrease

Increase

Debits and credits occur simultaneously in every financial transaction in double-entry bookkeeping.

**Expected Result** (Using [clipboard2markdown](http://euangoddard.github.io/clipboard2markdown/)) On the other hand, increases in revenue, liability or equity accounts are credits or right side entries, and decreases are left side entries or debits. | Kind of account | Debit | Credit | ---|---|---| | **Asset** | **Increase** | Decrease | | Liability | Decrease | **Increase** | | Income/Revenue | Decrease | **Increase** | | **Expense/Cost/Dividend** | **Increase** | Decrease | | Equity/Capital | Decrease | **Increase** | Debits and credits occur simultaneously in every [financial](https://en.m.wikipedia.org/wiki/Financial_accounting "Financial accounting") transaction in double-entry bookkeeping.
0x6b commented 3 years ago

Thanks for the issue @anishmittal2020. The part works for me. Can you please check your addon version? It should be:

Update to the latest by about:addonsGear icon at top-right → Check for updates, restart your browser, and retry please. As it's works for me it might be difficult to investigate and/or fix I'm afraid.

lamyergeier commented 3 years ago

@0x6b I have same Addon version, and I tried once again, I got exactly the same issue.

Firefox: 90 OS: Ubuntu 20.04 Extension Version: 0.21.0 Last Updated: 26 June 2021


These are my settings:

image

But nothing is logged in the console as follows:

image


I created a new Firefox profile with default settings and only this extension installed. But I get exactly the same behavior!

0x6b commented 3 years ago

@anishmittal2020 Can you try the page with checking Enable GitHub Flavored Markdown (strikethrough, tables, and taskListItems) support? Original Markdown syntax does not support table so you have to check the preference.

lamyergeier commented 3 years ago

Hi what you mentioned worked for the aforementioned example (but today it did not). I changed my settings before: (enabled tables)

image

Also, it does not work in this example: Attitudes, Beliefs, and Values SPCH 1311: Introduction to Speech Communication

Definition Changeable? Example
Attitudes Learned predispositions to a concept or object Subject to change I enjoyed the writing exercise in class today.
Beliefs Convictions or expressions of confidence Can change over time This course is important because I may use the communication skills I am learning in my career.
Values Ideals that guide our behavior Generally long lasting Effective communication is important.

It weorks with clipboard2markdown)

0x6b commented 8 months ago

@lamyergeier Thank you for your patience. After nearly 3 years of silence, I've released version 0.22.0, and it seems to be working fine with the URL. Please check and if you have something strange, please reopen the issue. Thanks!

lamyergeier commented 8 months ago

@0x6b The following table from File attribute - Wikipedia is rendered as below

image

Common file attributes supported by many common Linux file systems Attribute .mw-parser-output .monospaced{font-family:monospace,monospace}lsattr flag chattr option Semantics and rationale No `atime` updates `A` `+A,-A` [[atime record](https://en.wikipedia.org/wiki/Stat_(Unix))](https://en.wikipedia.org/wiki/Stat_(Unix) "Stat (Unix)") is not modified when file is read/accessed. Append-only `a` `+a,-a`

Writing to file only allowed in append mode.

Immutable `i` `+i,-i`

Prevents any change to file's contents or metadata: file/directory cannot be written to, deleted, renamed, or hard-linked.

No dump `d` `+d,-d` File is skipped by the [[dump program](https://en.wikipedia.org/wiki/Dump_(Unix))](https://en.wikipedia.org/wiki/Dump_(Unix) "Dump (Unix)") Secure deletion `s` `+s,-s` Requests that, when deleted, all file data blocks are [[filled with zeroes](https://en.wikipedia.org/wiki/Data_remanence#Overwriting)](https://en.wikipedia.org/wiki/Data_remanence#Overwriting "Data remanence"). Synchronous updates `S` `+S,-S` Changes are written synchronously to the underlying filesystem storage medium; equivalent to 'sync' mount option for affected files.

Expected Result (Using clipboard2markdown

Attribute lsattr flag chattr option Semantics and rationale
No atime updates A +A,-A [atime record] is not modified when file is read/accessed.
Append-only a +a,-a Writing to file only allowed in append mode.
Immutable i +i,-i Prevents any change to file's contents or metadata: file/directory cannot be written to, deleted, renamed, or hard-linked.
No dump d +d,-d File is skipped by the [dump program]
Secure deletion s +s,-s Requests that, when deleted, all file data blocks are [filled with zeroes].
Synchronous updates S +S,-S Changes are written synchronously to the underlying filesystem storage medium; equivalent to 'sync' mount option for affected files.

I think this issue should be reopened!