Closed li-ruijie closed 6 years ago
Soon I'll be merging your pull request into master, but I'll be reverting the ffmpeg command as your change does not work for me.
Just saw this. The -bsf:a aac_adtstoasc
was throwing up some error which was why I removed it. Unfortunately, I did not log it down. I am using ffmpeg
stable from choco
on Win 10 Pro x64.
I've attempted to replicate your environment and I'm not seeing the error you're describing. Attempted with the URL https://video.toggle.sg/en/series/while-we-are-young-z/ep15/550084 and the file downloads successfully with -bsf:a aac_adtstoasc
present in ffmpeg command.
Windows 10 x64 v1703
PS C:\Python27> choco list -li
Chocolatey v0.10.8
chocolatey 0.10.8
chocolatey-core.extension 1.3.3
ffmpeg 3.4
python2 2.7.14
vlc 2.2.6
Hence I'll be keeping the -bsf:a aac_adtstoasc
parameter as default. If you could let me know how your environment differs. I can add in an if-check to strip the parameters if your environment is matched.
The new subtitles URL works well, thanks! However, modification of the ffmpeg command causes the following error with a link such as https://video.toggle.sg/en/series/while-we-are-young-z/ep15/550084 (as referenced in #41):
Curious to know if you are facing the same error (which might point to a platform-specific ffmpeg implementation), and/or the reasons from removing the
-bsf:a aac_adtstoasc
parameter option.