search

0x776b7364 / toggle.sg-download

Python script to automate Toggle.sg video downloads
MIT License
26 stars 18 forks source link

Line 460 doesn't work in Windows #52

Closed win98se closed 6 years ago

win98se commented 6 years ago

Windows doesn't support os.uname(), so the line 460 (logger.debug(os.uname())) causes an error in Windows. I commented that line and everything else works as expected.

0x776b7364 commented 6 years ago

I'm not supporting Windows anymore; in any case, I believe platform.uname() should do the trick. Perhaps submit a PR? :)

NGPriest commented 6 years ago

I'm also having problems with the regex on line 73...

It should work in theory, but it doesn't seem to work in reality...

VALID_EPISODES_URL = r"http?://tv\.toggle\.sg/(?:en|zh)/.+?/episodes" to VALID_EPISODES_URL = r"https://tv\.toggle\.sg/(?:en|zh)/.+?/episodes"

0x776b7364 commented 6 years ago

@win98se Possible fix pushed as b930d1f

win98se commented 6 years ago

@0x776b7364 Thank you, solved.

@NGPriest There aren't any issues here with line 73 using http? instead of https.