search

0x7c13 / Notepads

A modern, lightweight text editor with a minimalist design.
https://www.NotepadsApp.com
MIT License
8.55k stars 469 forks source link

Patch 1 #1294

Closed Stephan-P closed 6 months ago

Stephan-P commented 6 months ago

Minor translation improvements

PR Type

Other information

I don't have a full Visual Code environment installed on my PC. That's too much for just the translation work. Most translation projects I'm involved with use environments like Weblate, Crowdin or Transifex for the translation work. For this project requiring resw files, I've found the Windows Store app Resx/ResW Editor & Translator (https://www.microsoft.com/store/productId/9MTPD7JZXNNN?ocid=pdpshare) I noticed that this tool has removed all the XML comments. Question: Do you want me to stop using this tool?

0x7c13 commented 6 months ago

Yeah, please keep the comments so that I can do direct comparison with all other languages, otherwise it would be hard to do sanity check.

0x7c13 commented 6 months ago

Github supports online VSCode editor with project pre-loaded when you editing a file:

image

Stephan-P commented 6 months ago

So, Do you want me to redo it in orde to keep the comments? I can give it a try...

Stephan-P commented 6 months ago

Feel free to reject the commit

Stephan-P commented 6 months ago

In my experience, the github.dev code editor is not very convenient as one has to search and find for the parts that need translating while taking care not breaking the code. It's doable, but one has to be careful.

Initially I used the Windows Store app Resx/ResW Editor & Translator (https://www.microsoft.com/store/productId/9MTPD7JZXNNN to do the translations in a more comfortable manner. Unfortunately this app removed the data, which was a hindrance in the reviewing process. When this became clear to me, I reported this as an issue with the maker of Resx/Resw Editor & Translator and he promptly took this upon himself. Today's version 2.0.425.0 of Resx/ResW Editor & Translator maintains the code and to me this looks like a viable option for those who want to initiate a new locale for Notepads.