search

0x90d / videoduplicatefinder

Video Duplicate Finder - Crossplatform
2.02k stars 194 forks source link

[Bug]: Update ImageSharp to support webp #516

Closed kattjevfel closed 5 months ago

kattjevfel commented 5 months ago

Environment

Describe the bug

ImageSharp 2+ supports webp but cd0f2959f218f57fed82f57a0d57c467440c501c reverted it to 1.0.4.

I made a contribution a long time ago adding support for webp but around the same time ImageSharp was downgraded so it no longer works and all webps are imported as black squares. About since then (just under 2 years ago now) I've reverted this commit and everything still works perfectly, making me wonder why this was ever reverted in the first place.

So, given that VDF works perfectly with newer versions of ImageSharp and is even improved by it, can it please be updated?

0x90d commented 5 months ago

given that VDF works perfectly with newer versions of ImageSharp

ImageSharp 2.1.8 and latest 3.1.4 for example the following APIs (which VDF uses) no longer exist:

TryGetSinglePixelSpan GetPixelRowSpan

This is why it stays on 1.0.4. If you say it works perfectly, I assume you have updated it to other APIs doing the same. Then feel free to make a PR.

kattjevfel commented 5 months ago

I actually just reverted your revert, and it has worked for 2 years now.

Latest rebase I did: https://github.com/kattjevfel/videoduplicatefinder/commit/98a3a58956a2f84383b32a0f98e8a266669516fc

0x90d commented 5 months ago

Feel free to make a PR

kattjevfel commented 5 months ago

https://github.com/0x90d/videoduplicatefinder/pull/517