Q: how do we know when a new cryptocurrency is added to the SDN?

[mrose17]

My guess from reading https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/main/generate-address-list.py#L12 is that someone periodically fetches the XML file, does a grep and then compares that to the list at https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/main/generate-address-list.py#L13-L15

I am wondering if a better implementation strategy might be to have the script do two passes: first, to look for <FeatureType/> starting with "Digital Currency Address - ", to build up the list on lines 13-15, and, second, to proceed as usual. of course, i'd still keep what's on lines 13-15, just as a safety.

Your thoughts?

[0xB10C]

I'm not actively monitoring for new coins being added to the SDN list - for me personally, only XBT is relevant. However, I accept PRs (https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/pull/7, https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/pull/6) to add new coins and will review and merge them.

As the CI is already running each night to check if there are new entries for the existing coins, there could also be a job that runs after uploading potential new entries - failing or otherwise alerting that there are new coins. Happy to create an issue for each new coin when the CI fails. Someone (not necessarily me, but I might do it if I have the time) can then create a PR to add the new coin.

[mrose17]

Thank you!

[0xB10C]

We might want to keep this open and not "closed as completed". The new CI task I was talking about doesn't exist yet. Someone might want to add that.

Reopening with the help wanted label.

[nickmura]

hey i was wondering if this is a related issue, let alone coins, but new addresses, on branch lists, does the github actions event still work where it updates addresses? does it update on an interval? looking at the commit history it doesn't seem to be a interval of changes. on what day of each month can we expect to see new addresses

[0xB10C]

The list branch is only updated when the underlying OFAC list changes - this happens infrequently. The OFAC list is downloaded an processed daily. See https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions and https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/319d5a6510c84fe01396387801dcc539a19a9f7f/.github/workflows/generate-lists.yml#L5-L7