search

0xB10C / peer-observer

Tool to monitor for P2P anomalies and attacks using Bitcoin Core honeynodes
https://public.peer.observer
MIT License
8 stars 1 forks source link

clean: rename `shared::wrapper::Wrapper` field wrap to event. #18

Closed 0xB10C closed 1 month ago

0xB10C commented 4 months ago

Currently, the shared::wrapper::Wrapper field wrap isn't really expressive of what it is. It's a peer-observer event and should be renamed.

image

0xB10C commented 4 months ago

Same goes for shared::wrapper::wrapper::Wrap

i-am-yuvi commented 3 months ago

Can I give it a try??

0xB10C commented 3 months ago

Sure, no need to ask!

i-am-yuvi commented 2 months ago

@0xB10C I basically need to replace the Wrap field inside the struct to event right??

0xB10C commented 2 months ago

Correct. Keep in mind that this Rust code is generated from protobuf definitions. You'll need to rename them and update the places where wrapper or wrap is currently used. The rust compiler should complain at the right places.

https://github.com/0xB10C/peer-observer/blob/master/protobuf/proto-types/wrapper.proto

i-am-yuvi commented 2 months ago

Yes, it is already commented that structs are generated from the protobuf definitions.

i-am-yuvi commented 2 months ago

I think we can also rename it to event.proto ?? @0xB10C

0xB10C commented 2 months ago

agree

i-am-yuvi commented 2 months ago

I have updated everything from wrap -> event & Wrapper -> Event. Is that fine??

0xB10C commented 2 months ago

Feel free to open a PR and I'll have a look there

0xB10C commented 1 month ago

Addressed with #25