search

0xB10C / peer-observer

Tool to monitor for P2P anomalies and attacks using Bitcoin Core honeynodes
https://public.peer.observer
MIT License
12 stars 2 forks source link

Various cleanups tracking issue #21

Open 0xB10C opened 5 months ago

0xB10C commented 5 months ago

Posting potential cleanups and small refactors that should be made at some point here:

0xB10C commented 5 months ago

Addressing these TODOs would be good

https://github.com/0xB10C/peer-observer/blob/4e4bb14cdf2d16dc6707599a25873e36dc49fb0d/shared/src/ctypes.rs#L49-L69

0xB10C commented 5 months ago

MAX_SMALL_MSG_LENGTH in this comment is incorrect. It should be N. Also, there's a typo in acccctual

https://github.com/0xB10C/peer-observer/blob/4e4bb14cdf2d16dc6707599a25873e36dc49fb0d/shared/src/ctypes.rs#L110

fixed with #22

0xB10C commented 5 months ago

More todos that can be addressed

https://github.com/0xB10C/peer-observer/blob/4e4bb14cdf2d16dc6707599a25873e36dc49fb0d/shared/src/ctypes.rs#L133-L138

0xB10C commented 5 months ago

https://github.com/0xB10C/peer-observer/blob/4e4bb14cdf2d16dc6707599a25873e36dc49fb0d/shared/src/ctypes.rs#L538-L544

0xB10C commented 5 months ago

typo: https://github.com/0xB10C/peer-observer/blob/4e4bb14cdf2d16dc6707599a25873e36dc49fb0d/shared/src/ctypes.rs#L619