search

0xD34D / klipper_ender3_v3_se

Klipper is a 3d-printer firmware
GNU General Public License v3.0
85 stars 13 forks source link

Z_Adjust doesn't save when restarting printer #4

Closed gadgethd closed 10 months ago

gadgethd commented 10 months ago

Describe the bug Z_Adjust doesnt apply when restarting printer as it is not a saved value by Klipper, it seems.

To Reproduce Steps to reproduce the behavior:

  1. Do a Z auto calibrate
  2. Save Config and restart
  3. see value gets removed after restart

Before restart:

Screenshot 2023-11-18 at 2 06 20 am

After restart:

Screenshot 2023-11-18 at 2 07 09 am

Expected behavior Whole Z offset to be saved on restart

Additional context

I believe this could be fixed by changing line 834 to include nozzle_z_offset in the calculation, then it would save as if it were a regular offset.

pi3123 commented 10 months ago

The ZOffset is saved to the printer.cfg under [bltouch] It doesn't save to the regular offset but it definetily saves it after running the SAVE_CONFIG

gadgethd commented 10 months ago

Yes the normal Z offset is saved, however the Z_Adjust doesnt get saved as its in the temp Z offset.

gadgethd commented 10 months ago

Ok so ive figured out why its doing this, its quite smart and I didn't notice. The temporary value is the difference between the previous Auto Z Offset and the new one, so you don't have to restart the printer. I think this is what you were mentioning before and I didn't fully understand it.