search

0xFEEDC0DE64 / esp-gui-lib

ESP32 gui library
GNU General Public License v3.0
2 stars 1 forks source link

[Feature] Skip MenuItem #8

Closed CommanderRedYT closed 2 years ago

CommanderRedYT commented 2 years ago

A MenuItem that acts like an empty one but skips (so just for design)

0xFEEDC0DE64 commented 2 years ago
  1. Add virtual bool visible() const { return true; } to MenuItem or introduce a new VisibleInterface
  2. in menu rendering code, call continue; whenever a menuitem is not visible, which should result in correct delta rendering with my existing Label widgets.
CommanderRedYT commented 2 years ago

What if its already been drawn? Will it clear the space? Or is it constant and not changeable? Also for the scroll behavior, should there be a option to skip the element as if it was not there or should it be selectable like the current empty-text menu items.

Will open a pull request, also, with a new Class so one can just type

espgui::constructMenuItem<espgui::Empty item>();

(Name tbd)