Implement player handles

0xFableOrg / 0xFable

A fully on-chain trading card game. There will be elves, wizards & shit. Drama and broken friendships also.

https://twitter.com/0xFableGame

BSD 3-Clause Clear License

103 stars 35 forks source link

Implement player handles #117

Open norswap opened 5 months ago

norswap commented 5 months ago

Two key features:

resolve players ENS if they have one, use https://viem.sh/docs/ens/actions/getEnsName.html
Add a PlayerHandle contract where users can register a single handle for their address (they should be able to change it as well)
- Handles should be unique
- Add a checkHandleValidity function that restricts names (e.g. only ASCII, minimum 5 characters, maybe not contain dots (to avoid ENS / other name system clashes)
- Add a checkPlayerEligibility that can be always true for now but down the line will only enable players that have completed some milestones (e.g. minimum amount of matches, minimum spend, ...) to register handles to avoid squatting.
- If a user has an ENS, let them select whether they want to use their handle or their ENS.
- Add an admin role that can be used later to avoid impersonation and squatting of popular names.

The frontend must be modified to display player handles (or ENS).

faytey commented 5 months ago

can i hop on this?

norswap commented 5 months ago

Go ham :)

faytey commented 5 months ago

Thanks I'd work on this, for better context, I'd be writing a cairo contract to handle Player Ens/profile and updating the frontend showing their ens right?

norswap commented 5 months ago

No, we're using Solidity on this game as we target an EVM rollup chain. Cairo contracts only work on Starknet.

saimeunt commented 5 months ago

@faytey have you started working on this? I'd like to take this one if you change your mind and work on something else please.

faytey commented 5 months ago

Just seeing this notification @saimeunt yes you can go ahead. @norswap I’d take up other issues thanks

faytey commented 2 months ago

If this issue is still up, i would love to continue working on it @norswap

saimeunt commented 2 months ago

Hey I'm no longer actively working on this feel free to pick it @faytey

faytey commented 2 months ago

Hey I'm no longer actively working on this feel free to pick it @faytey

Cool, @norswap is this okay?

norswap commented 2 months ago

Yes, go for it!

faytey commented 2 months ago

Hi Sir @norswap I made a PR to this issue here 117 I need your review and comments sir.

faytey commented 2 months ago

@norswap

Hi Sir @norswap I made a PR to this issue here 117 I need your review and comments sir.

norswap commented 1 month ago

Sorry, things have been hectic these days. I will try to review this as soon as possible, but it might still take a few days!