search

0xFableOrg / 0xFable

A fully on-chain trading card game. There will be elves, wizards & shit. Drama and broken friendships also.
https://twitter.com/0xFableGame
BSD 3-Clause Clear License
103 stars 35 forks source link

Add Github CI checks for linting etc #119

Closed norswap closed 5 months ago

norswap commented 5 months ago

We should run the global makefile's make check in github CI and ensure it exits with a zero error code (meaning everything passed as expected).

Here's an example of the same thing in the roll-op repo.

Note that we don't need to "build": the contracts tests will build them automatically, and the typescript code doesn't need a build step. HOWEVER, we will need make setup first to install all dependencies.

ptisserand commented 5 months ago

Hi, can I take this issue?

ptisserand commented 5 months ago

Should I include fix for typescript linter issue in my PR or is it better to have another one to ensure that linter issues are detected by CI ?

norswap commented 5 months ago

Should I include fix for typescript linter issue in my PR or is it better to have another one to ensure that linter issues are detected by CI ?

It can be in the same PR if there are some remaining linting issues, just make sure they're in separate commits (ideally each lint fix in a separate commit).