0xFableOrg / 0xFable

A fully on-chain trading card game. There will be elves, wizards & shit. Drama and broken friendships also.

https://twitter.com/0xFableGame

BSD 3-Clause Clear License

103 stars 35 forks source link

detect offline client #129

Closed Blazing-Mike closed 3 months ago

Blazing-Mike commented 5 months ago

Context (Problem, Motivation, Solution)

Link related issues! i ran into git conflict so i had to pull. open another PR

126 #35

Describe Your Changes

Checklist

[x] I have performed a self-review of my code
[x] I ran make check and fixed resulting issues
[x] I ran the relevant tests and they all pass
[ ] I wrote tests for my new features, or added regression tests for the bug I fixed

Testing

I implemented a modal to display when our app is offline. so how did i test this, i tested this by throttling the network in my devtools and also disconneCTING my device from wifi and this modal appears on the index.tsx and play.tsx page. when i toggle back or reconnect, the modal disaappears

CC: @norswap

Blazing-Mike commented 4 months ago

@norswap please i need a review on this PR.

norswap commented 4 months ago

Hey, time is a bit tight right now, but I'll get to it soon. Don't worry, this'll be considered for ODHack.

Blazing-Mike commented 4 months ago

I understand. Thank you.

norswap commented 4 months ago

Hey, any updates on this?

Blazing-Mike commented 4 months ago

Yess. I have fixed the implementation to just rely on offline and online events. And it works when I switched off WiFi and turned it on.

Blazing-Mike commented 4 months ago

cc @norswap

norswap commented 4 months ago

Sorry, I missed that extra commit. Looks good, could you rebase on top of master and make sure make check passes? (You'll want to run make format first.)

Blazing-Mike commented 4 months ago

Sorry, I missed that extra commit. Looks good, could you rebase on top of master and make sure make check passes? (You'll want to run make format first.)

Done ✅. make check passes.

Cc: @norswap

Blazing-Mike commented 4 months ago

Hi norswap.Just reminding you of this PR, make check have passed.

norswap commented 4 months ago

Hey, I see you merged instead of rebasing, do you think you could get that fixed? If not, it's okay, just let me know and I'll perform the rebase myself :)

Blazing-Mike commented 4 months ago

I am running into some issues with it. could you help please? thank you.

Blazing-Mike commented 4 months ago

it's me again 🙂...just wanna check if the or is merged. Have a productive week ahead.

Cc: @norswap

norswap commented 4 months ago

Hey, I'm unfortunately super buy and hadn't time to deal with this, but I'll get it sorted!

Blazing-Mike commented 3 months ago

finally 😃!!I feel so elated looking forward to contributing more to this project.