search

0xFableOrg / 0xFable

A fully on-chain trading card game. There will be elves, wizards & shit. Drama and broken friendships also.
https://twitter.com/0xFableGame
BSD 3-Clause Clear License
103 stars 35 forks source link

Card draw animation plays on initial hand #133

Open norswap opened 4 months ago

norswap commented 4 months ago

We have an animation that scrolls the hand to the latest card drawn and highlights it.

Currently this also occurs when entering the game for the first time, which is not intended (as all cards are newly drawn, highlighting the last one doesn't make sense).

Xaxxoo commented 4 months ago

Hi @norswap, I am interested in this.

norswap commented 4 months ago

Hey, you need to check in with @ultraviolet10 to see if he hasn't tackled this yet. He will be touching that part of the codebase, so it's important to coordinate with him regardless — it might be better to leave him to it, but he will weigh in himself!

ultraviolet10 commented 4 months ago

Hi @Xaxxoo I've just fixed this in a local branch, will push this to a PR soon (alongwith some other fixes) :)

Joy-Adah commented 2 months ago

Hi @norswap is this still available?

norswap commented 2 months ago

No, as you see above, @ultraviolet10 has fixed it. @ultraviolet10 What PR is this in?