Closed faytey closed 6 days ago
I need your review on this before proceeding @norswap , Also I'm encountering errors setting up the webapp
I need your review on this before proceeding @norswap , Also I'm encountering errors setting up the webapp
Hello @norswap still awaiting your review
Hi Sir I'd get started on these and update, sorry for the delay
Hi Sir, I have made requested corrections
Great work! Could you just make sure the Mock ENS resolver is logged + included in deployments.ts as well?
Also it seems you've made changes to the lockfile, could just revert it to the master version so that no changes show? The current file seems incorrect in some way, as shown by the failing CI check.
Also it seems you've made changes to the lockfile, could just revert it to the master version so that no changes show? The current file seems incorrect in some way, as shown by the failing CI check.
Hi Sir, I didn't make any changes to the lockfile and can't seem to understand how to rectify it.
That was probably accidental, you can see it is changed in "Files changes" here on Github.
Fixing it requires a little bit of git foo:
You can revert it by using git checkout master -- pnpm-lock.yaml
then git add pnpm-lock.yaml
.
You could then git commit and push that, but let's squash all your commit together:
git reset --soft HEAD~7 && git commit
(The 7 here is the number of commits you've made, so if you add additional commits in between you need to update that number.)
Then finally git push --force-with-lease
to replace the commits here with the single squashed commit.
That was probably accidental, you can see it is changed in "Files changes" here on Github.
Fixing it requires a little bit of git foo: You can revert it by using
git checkout master -- pnpm-lock.yaml
thengit add pnpm-lock.yaml
. You could then git commit and push that, but let's squash all your commit together:git reset --soft HEAD~7 && git commit
(The 7 here is the number of commits you've made, so if you add additional commits in between you need to update that number.)
Then finally
git push --force-with-lease
to replace the commits here with the single squashed commit.
done sir
Hello sir @norswap
Thanks! Did some extra cleanup and merged here: https://github.com/0xFableOrg/0xFable/pull/137
Context (Problem, Motivation, Solution)
Link related issues! Issue 117
Describe Your Changes
I added the smart contract to implement Player handles and wrote the tests to check the functions work properly
Checklist
make check
and fixed resulting issuesTesting
If you didn't write tests, explain how you made sure the code was correct and working as intended.