Open norswap opened 1 year ago
@norswap Kindly assign this to me. I would love to tackle it.
Hey there! This is probably pretty ambitious as the web version isn't ready yet, but I'd love to see a prototype if you want to tackle it. Not going to assign on this issue, it's not really "ready for prime time".
Hi @norswap, so I have been having issues with running the code. The "make" commands in the readMe files are the issues and as such I can't see the frontend.
Going back to your initial reply, do you mean I should build an entirely new prototype independent of what you already have? If yes, then there is no issues. I can go ahead and start right away.
Tell me more about the exact issues you're encountering. Did you follow the setup instructions and then the Running instructions?
The prototype should be semi independent, you could make it into a new directory under packages/webapp/src
for now, or a new package under packages
, but reuse logic from packages/webapp
— whatever is easier for now, we'll figure out the best way to package later.
If you're tackling this, could you start by providing a wireframe of the proposed UI?
Oh yes, I followed the instructions and two out of the 4 make commands return errors. Is there a way I can detach the frontend and have it run so I can see the logic of the game.
As for the wireframe, I'll come up with one and share.
Please send the errors here.
Please send the errors here.
For Make Deploy: cd packages/contracts && make deploy forge build dyld[12171]: Library not loaded: '/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' Referenced from: '/Users/Dijha/.foundry/bin/forge' Reason: tried: '/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/usr/local/lib/libusb-1.0.0.dylib' (no such file), '/usr/lib/libusb-1.0.0.dylib' (no such file) make[1]: [build] Abort trap: 6 make: [deploy] Error 2
For make anvil: bash-3.2$ cd packages/contracts && make anvil anvil --chain-id 1337 --block-time 2 dyld[10968]: Library not loaded: '/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' Referenced from: '/Users/Dijha/.foundry/bin/anvil' Reason: tried: '/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/usr/local/lib/libusb-1.0.0.dylib' (no such file), '/usr/lib/libusb-1.0.0.dylib' (no such file) make: *** [anvil] Abort trap: 6
You've got an issue w/ your Foundry install - try going to the foundry Github & following the instructions for running foundryup
.
From the message, seems like you're missing libusb. See here: https://github.com/foundry-rs/foundry/discussions/481
Also, I don't mean to be rude but rather upfront - if you can't diagnose stuff like this, this project might be too much to chew off for you!
Clearly, the current UX is not ideal for mobile. We could force landscape mode and scale the UI and things would be usable (similar to how other card games tend to be played on mobile, e.g. Hearthstone or Gwent), but I'd like to do something more natural.
My strawman proposal is a list of vertical "drawers" each with a heading that collapses/expands the drawer when clicked. Each drawer represents a game area (hand, our side of the battlefield, the opponent side of the battlefields, the player's graveyards...) and within each drawer the cards in the corresponding area are listed. This could be as icons or just as a bunch of lines listing the name of the cards (or this could even be configurable).
The UX flow would generally be fairly similar to the desktop version (see the relevant epic), though it obviously need adaptations. Drag and drop should be removed in favour of buttons. For assigning blockers, deciding to block should pop a list of valid blocking targets to select from.