0xFableOrg / 0xFable

A fully on-chain trading card game. There will be elves, wizards & shit. Drama and broken friendships also.
https://twitter.com/0xFableGame
BSD 3-Clause Clear License
106 stars 39 forks source link

Try using Vite instead of Next.js #43

Closed norswap closed 6 months ago

norswap commented 1 year ago

Currently we use Next.js for building and routing. Next has been rather easy to work with, but it has two disadvantages:

I've heard that Vite has clean source maps, so I'm interested to try it out and compare.

Swapping out Next also means we need an alternative routing solution — something like react-router maybe? Open to alternatives as long as it's fairly lightweight and doesn't pull in a bunch of stuff we don't need.

cwkang1998 commented 1 year ago

I think something like vite + react + react-router is going to be okay. Not very sure about the exact bundle size but I can try it out and give a comparison.

Xaxxoo commented 6 months ago

@norswap I would like to handle this.

norswap commented 6 months ago

I think this is no longer a priority at this point, we have a good way to avoid server-side rendering issues (useIsHydrated) and the source map seem to work now.

It would also force us to change the way we handle routing, which we have customized quite a bit for passing around extra parameters (which enable sending transaction with an in-browser private key for testing purposes).

I'm sorry about the confusion, I'll be closing this now!