Improve Linting

[norswap]

Context (Problem, Motivation, Solution)

The Github issues asks for people to lint, but we haven't actually done this consistently. This PR intends to put the code in a linted state + improves the tooling around linting.

Describe Your Changes

• Linted contract code
• Made sure compiled circuits could be make installed from circuits repo and would work, and not case any undue warning or linting issue
  • The current verifier code was not consistent with the circom code in the repo! Fixed the code there to make things compile / let tests pass (circuit integration w/ contracts is untested atm).
  • Avoiding linting problems required excluding the contracts from linting by moving them to a specific repo and specifying the other repos explicitly.
  • I add to ignore some warnings in solc (unused parameters), but make lint will still check for them (just not in Circom contracts).
• Removed the dependency on prettier in favour of using forge fmt to format code.

TODO:

• Similarly lint the frontend code.

Checklist

• [x] I have performed a self-review of my code
• [x] I ran make lint and fixed resulting issues
• [x] I ran the relevant tests and they all pass
• [x] I wrote tests for my new features, or added regression tests for the bug I fixed

[norswap]

@eerkaijun Do you know why the existing contracts add bytes calldata _proof parameters, but those I'm generating with Circom (I have version 2.1.4) have uint256[24] calldata _proof instead?

[eerkaijun]

@norswap Hmmm I just tried regenerating the verifier contract and it's giving me bytes calldata _proof as the parameters. I have 2.1.4 for circom too. What is your snarkjs version?

[eerkaijun]

Okay seems like snarkjs recently just upgraded to 0.7.x version and I am using a slightly older version (0.6.11). Once I upgrade my snarkjs then I got the same parameters as you.