search

0xInfection / TIDoS-Framework

The Offensive Manual Web Application Penetration Testing Framework.
GNU General Public License v3.0
1.77k stars 387 forks source link

[Bug] => Python 3 treats TabErrors as syntax errors #41

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

Indentation should be all tabs or all spaces but not a mix of the two in Python 3.

https://travis-ci.com/theInfectedDrake/TIDoS-Framework/jobs/150198095#L477

0xInfection commented 5 years ago

Now I guess you understand the reason the reason why I defaulted Travis to build on Python 2 only for present. Check the updated .travis.yml

I am coding almost the entire framework from scratch, so I guess there shouldn't be any in v2.

cclauss commented 5 years ago

451 days until Python 2 end of life... http://pythonclock.org

0xInfection commented 5 years ago

451 days until Python 2 end of life... http://pythonclock.org

Why else so you expect me to rewrite the whole code? 🙂

cclauss commented 5 years ago

A complete rewrite is not at all necessary. Small cleanup != rewrite.

37 was the bulk of the work and that is already merged. TabErrors are just whitespace changes.

0xInfection commented 5 years ago

Nah, I am not just doing the whole rewrite for this petty indentation error, the stuff is have planned for v2 has provisions that there are bulk additions that have to be made to almost all modules. #37 was the first PR of this repo and was huge, I seriously didn't want to spill your work away just like that.

To be honest, I wrote this code in a messed-up+spaghetti way check the source, very casually cause I never expected TIDoS to grow this big. I mean like look at the way I wrote the code 😂, its not even a real framework structure. But since it has grown to this, a total code refactor is highly necessary. 🙂

cclauss commented 5 years ago

Are you married to tabs or could we run https://github.com/python/cpython/blob/master/Tools/scripts/reindent.py on the codebase?

0xInfection commented 5 years ago

I just noticed that somehow I had mistakenly closed this, oops. However, as already you know, contributions to this framework are always welcome, feel free to do anything which according to you might help in the improvisation of the overall build. I would gladly review and accept them.

Oh and by the way, you should give me your real name and contact info which is to be included in the AUTHORS file, since you're one of the top contributors to this project. Hit me up personally on twitter if it's sensitive here.

0xInfection commented 5 years ago

On the way to be fixed 😀👌.