0xPIT / encoder

Atmel AVR C++ RotaryEncoder Implementation
309 stars 162 forks source link

to use WITHOUT_BUTTON causes compile error #16

Open mcdonaldajr opened 7 years ago

mcdonaldajr commented 7 years ago

when defining WITHOUT_BUTTON I got a compile error, bool accelerationEnabled undefined. Looking at the code, the #endif included the declaration of accelerationEnabled; by moving the #endif up one line, this fixed the problem.

ifndef WITHOUT_BUTTON

volatile Button button; bool doubleClickEnabled;

endif

bool accelerationEnabled; //#endif -- the was in the wrong place

soligen2010 commented 7 years ago

You must have a very old version as this was fixed over a year ago. You might want to check out the soligen2010 fork as it has other bug fixes and enhancements added to it as well.

mcdonaldajr commented 7 years ago

Thanks. Will do.

On 3 Mar 2017, at 21:49, Dennis notifications@github.com wrote:

You must have a very old version as this was fixed over a year ago. You might want to check out the soligen2010 fork as it has other bug fixes and enhancements added to it as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/0xPIT/encoder/issues/16#issuecomment-284079426, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4bH5yDQ74d4NhT0Gub_4Bd0eLpJudDks5riIrUgaJpZM4MScwB.