0xPIT / encoder

Atmel AVR C++ RotaryEncoder Implementation
309 stars 162 forks source link

Wiring #28

Open kyberkiller opened 6 years ago

kyberkiller commented 6 years ago

I don't see any input_pullups in code as assumed (like in constructor?), no idea where to connect the button's other end and encoder's common pin. Adding one or two sentences in readme would be really helpful and add value to your library.

If some general understanding of encoder electrical connections is expected, please add relevant links.

krukhlis commented 6 years ago

Author has already provided response in the same issue created long ago. Please check https://github.com/0xPIT/encoder/issues/7: