Closed cvauclair closed 1 month ago
Looks good. I also see there's an opportunity for fluid builder design on the
openai_client.embedding_model(...)
that could make it a bit cleaner but understandably makes the requirements on other provider clients a bit hazy.
I think we might end up with traits for Clients to simplify this integration, but that will be tackled in another issue!
InMemoryVectorStore::from_documents
utility methodInMemoryVectorStore::from_embeddings
utility methodPreviously:
Can now be written as:
Or even shorter if using
InMemoryVectorIndex::from_documents
!