search

0xPlaygrounds / subgrounds

An intuitive Python library for interfacing with subgraphs and GraphQL
http://docs.playgrounds.network
Apache License 2.0
50 stars 8 forks source link

Relaxed versions for pyproject #57

Closed gabrielfior closed 4 months ago

gabrielfior commented 4 months ago

We are using subgrounds for our data fetching on Gnosis. It would be great to have these new dependencies in-place.

0xMochan commented 4 months ago

Unfortuntely, I messed up the squash somehow but I've merged this!

gabrielfior commented 4 months ago

@0xMochan thanks for merging! I want to integrate these changes with my package (using poetry), but the last released version was 1.8.1 (see https://pypi.org/project/subgrounds/#history). Are you planning to release a new version soon with these changes? Thanks

0xMochan commented 4 months ago

ah, i didn't realize our auto-release flow didn't trigger. I'll look into it!

0xMochan commented 4 months ago

hmm, actually can you explain more why you needed some of the dependencies to be a bit newer. the ^ symbol for versions should allow for newer patch versions if a project depending on subgrounds require it, as long as it's specified in a downstream pyproject.toml. There's not a specific requirement for subgrounds to be using newer versions in libs like pydantic.

The lack of pypi releases was due to a lack of verification on our emails. Not sure how the CI didn't fail for this as I haven't noticed this but I've resolved it now.

gabrielfior commented 4 months ago

hmm, actually can you explain more why you needed some of the dependencies to be a bit newer. the ^ symbol for versions should allow for newer patch versions if a project depending on subgrounds require it, as long as it's specified in a downstream pyproject.toml. There's not a specific requirement for subgrounds to be using newer versions in libs like pydantic.

That was an error from my side. Your reasoning is correct - being more strict on Pydantic does not help. I created a PR (#58 ) to fix this.

The lack of pypi releases was due to a lack of verification on our emails. Not sure how the CI didn't fail for this as I haven't noticed this but I've resolved it now.

It would be great to have a published package for this new version (1.9.1) soon, as we want to point our poetry dependency to the new release on PyPI (for some reason, publishing a PyPI package which has a dependency of type {git=, rev=""} makes poetry publish throw an error.