0xPolygon / kurtosis-cdk

A Kurtosis package that deploys a private, portable, and modular Polygon CDK devnet
https://docs.polygon.technology/cdk
Apache License 2.0
29 stars 47 forks source link

feat: enable support for pre-deployed contracts #112

Closed leovct closed 2 months ago

leovct commented 2 months ago

Description

You can now specify the rollup manager address in addition to the zkevm rollup chain id in params.yml to automatically retrieve the rollup data from the RollupManager contract.

## Rollup configuration.

# The chain id of the new rollup.
zkevm_rollup_chain_id: 10101

# The fork id of the new rollup. It indicates the prover (zkROM/executor) version.
zkevm_rollup_fork_id: 9

# The address of the rollup manager contract on L1.
# If specified, the rollup data will be retrieved from this contract instead of using the contracts service.
zkevm_rollup_manager_address: "0x2F50ef6b8e8Ee4E579B17619A92dE3E2ffbD8AD2"

This feature allows to use pre-deployed contracts on L1 which could speed up local deployments - you only need to deploy L1 and contracts once and then you can specify the address of the rollup manager contract - and it could also enable starting the stack against any L1 like Sepolia.

A new job has been introduced to test the behaviour of the package against a local L1 chain with pre-deployed zkevm contracts (see pre-deployed-contracts).

Other

This PR also fixes a problem with the input parser. If a value (for example d) is specified in params.yml and it is not part of the default args, then the result args will not contain d. This is a problem for non-default parameters such as zkevm_rollup_manager_address.

Printing a message
input_args

Printing a message
{"a": 11, "b": 22, "d": 44}

Printing a message
default_args

Printing a message
{"a": 1, "b": 2, "c": 3}

Printing a message
result

Printing a message
{"a": 11, "b": 22, "c": 3}

Printing a message
patched result

Printing a message
{"a": 11, "b": 22, "c": 3, "d": 44}

fyi @xavier-romero

References (if applicable)

https://polygon.atlassian.net/browse/DVT-1433

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud