0xPolygon / kurtosis-cdk

A Kurtosis package that deploys a private, portable, and modular Polygon CDK devnet
https://docs.polygon.technology/cdk
Apache License 2.0
41 stars 72 forks source link

Permissionless requires genesis artifact #126

Closed praetoriansentry closed 4 months ago

praetoriansentry commented 4 months ago

System information

Debian

Commit id

894c89c555fbfeb535df9a54fda206ab0fc401f5

Tools versions

Checking that you have the necessary tools to deploy the Kurtosis CDK package... ✅ kurtosis 0.89.10 is installed, meets the requirement (>=0.88.9). ✅ docker 26.1.3 is installed, meets the requirement (>=24.7).

You might as well need the following tools to interact with the environment... ✅ jq 1.7 is installed. ✅ yq 0.0.0 is installed, meets the requirement (<=3.x). ✅ cast 0.2.0 is installed. ✅ polycli v0.1.43-32-gb921b11 is installed.

🎉 You are ready to go!

Description & steps to reproduce

The docs show how to run the permissionless node, but this seems like it's no longer supported because:

  1. The refactored args in params.yml makes it so we can't directly load zkevm_permissionless
  2. The genesis artifact is retrieved even if we have everything but permissionless disabled. In that case, it should be rendered from the template. image

Desired behavior

The documented approach for running a permissionless node should work. The easiest fix I think is to avoid referencing the genesis artifact if it wasn't created / doesn't exist.

What is the severity of this bug?

Papercut; This bug is frustrating, but I have a workaround.