enableDataDogProfiler() err check is wrong - Githubissues

0xPolygon / polygon-edge

A Framework for Building Ethereum-compatible Blockchain Networks

https://polygon.technology/solutions/polygon-edge/

Apache License 2.0

1.01k stars 534 forks source link

enableDataDogProfiler() err check is wrong #2201

Open R-Santev opened 3 months ago

R-Santev commented 3 months ago

enableDataDogProfiler() err check is wrong

Description

A wrong variable is checked for error is made in server/server.go:175

Your environment

OS and version. Irrelevant.
The version of the Polygon Edge.
Version 1.3.3
The branch that causes this issue. develop
Locally or Cloud hosted (which provider). Irrelevant.
Please confirm if the validators are running under containerized environment (K8s, Docker, etc.). Irrelevant.

Expected behavior

Tell us what should happen. " DataDog profiler setup failed" must be logged when ddErr is != nil
Tell us what happened instead. It doesn't enter the if statement

Proposed solution

I am attaching a PR resolving the issue: https://github.com/0xPolygon/polygon-edge/pull/2200

Faiqonli commented 1 month ago

server/server.go:175