search

0xPolygonHermez / cdk-erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
35 stars 38 forks source link

ProviderError too many arguments, want at most 1 #1077

Closed omnifient closed 1 month ago

omnifient commented 2 months ago

Someone deploying their smart contracts on Polygon ZkEVM reported an error during their deployment process using https://zkevm-rpc.com/

The error that's surfaced back by hardhat is ProviderError too many arguments, want at most 1. After some searching, it seems like it might be related to this which in turn is referenced by eth_estimateGas Errors occur on other chains and EstimateGas support the latest hardhat.

They were able to deploy on other chains without issues, including X Layer. They were also able to deploy without issues on ZkEVM using the legacy rpc (https://rpc-legacy.zkevm-rpc.com/), which hints that the problem is caused by the Erigon client.

Unfortunately the deployment process is not simple, so the error could be caused by any endpoint. One interesting data point is that the error did not cause the the deployment transaction to fail, so it suggests being in a read-only endpoint?

Internal slack discussion link

praetoriansentry commented 2 months ago

I created #1078 based on looking into this issue. I've confirmed that the RPCs used during a trivial hard hat deployment work fine. I can't definitively say that #1078 caused their issue. I'd be surprised if they have a dependency on a non-standard parameter in eth_getTransactionByHash, but it's possible. Either way we should address the discrepancy and review the RPCs for other discrepancies that could cause issues like this.

V-Staykov commented 2 months ago

1078 is now fixed

omnifient commented 2 months ago

thanks @V-Staykov any idea when will this get pushed into the mainnet nodes?

V-Staykov commented 2 months ago

No. Maybe with release 19.