search

0xPolygonHermez / cdk-erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
35 stars 32 forks source link

[Sequencer] log messages when overflowing counters are causing confusion. #1309

Open hexoscott opened 3 hours ago

hexoscott commented 3 hours ago

The logs messages when we attempt to add a transaction to a batch and it overflows counters are confusing as it looks like a single transaction is overflowing the counters and that it is somehow invalid. We need to soften the message below to make it clearer that we're simply trying to maximise the batch capacity and the tx will be attempted in the next batch.

log.Info(fmt.Sprintf("[%s] transaction %s overflow counters", logPrefix, txHash), "count", batchState.overflowTransactions)
hexoscott commented 2 hours ago

We should also log the current state of the steps in this message to show what is going on, maybe just the ones that overflowed and by how much. So make it clear that this single transaction took the batch from 10k steps to 50k steps so we'll try in the next batch.